----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29056/#review65145 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java <https://reviews.apache.org/r/29056/#comment108119> If this.repositoryVersion == null while that.repositoryVersion is not null, then the equals will ignore that field. - Alejandro Fernandez On Dec. 15, 2014, 5:13 p.m., Yurii Shylov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29056/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2014, 5:13 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate > Cole. > > > Bugs: AMBARI-8718 > https://issues.apache.org/jira/browse/AMBARI-8718 > > > Repository: ambari > > > Description > ------- > > Instead of `stack` and `version` fields in `cluster_version` and > `host_version` there should be an FK pointing to repo_version. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java > 4d0fb31 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java > 09f9b7f > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java > e26a800 > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/DistributeRepositoriesActionListener.java > 428a0d2 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java > a7d4d24 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java > c090056 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > c54e13a > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java > 8d2a902 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java > 487b216 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql e09a0c2 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 0b3c831 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 203b5bb > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > e311276 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql c044ff6 > > ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java > c6e5b26 > > ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java > 26bf0b9 > > ambari-server/src/test/java/org/apache/ambari/server/api/services/StacksServiceTest.java > 268c008 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 665d983 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java > c31cc37 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java > 9b5a52a > ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java > cc79f09 > ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java > fed9827 > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java > 4b29635 > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java > 44bdf94 > > ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java > 652299c > > ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java > 54c341f > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java > 9cdb9ad > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java > 0d55792 > > ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java > ab158e9 > > ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java > 2a04c71 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java > 4cf1b40 > > Diff: https://reviews.apache.org/r/29056/diff/ > > > Testing > ------- > > [INFO] Ambari Groovy Shell ............................... SUCCESS [10.999s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 50:31.099s > [INFO] Finished at: Mon Dec 15 15:04:55 CET 2014 > [INFO] Final Memory: 46M/674M > > > Thanks, > > Yurii Shylov > >
