----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29080/#review65199 -----------------------------------------------------------
Ship it! Looks fine to me. - Robert Nettleton On Dec. 16, 2014, 2:38 a.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29080/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2014, 2:38 a.m.) > > > Review request for Ambari, dilli dorai, John Speidel, Robert Nettleton, and > Yusaku Sako. > > > Bugs: AMBARI-8725 > https://issues.apache.org/jira/browse/AMBARI-8725 > > > Repository: ambari > > > Description > ------- > > Add _injected_ 'org.apache.ambari.server.state.Clusters' into > 'org.apache.ambari.server.serveraction.kerberos.KerberosServerAction' so that > the relevant cluster object ('org.apache.ambari.server.state.Cluster') may be > retrieved and used to help get access to the KDC administrative credentials. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java > 832602f > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java > 65e5cd6 > > Diff: https://reviews.apache.org/r/29080/diff/ > > > Testing > ------- > > Updated to inject `org.apache.ambari.server.state.Clusters` object into > `org.apache.ambari.server.serveraction.kerberos.KerberosServerAction` > Running > org.apache.ambari.server.serveraction.kerberos.KerberosServerActionTest > Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.727 sec > > Full Test Suite > Tests run: 2427, Failures: 0, Errors: 0, Skipped: 13 > > > Thanks, > > Robert Levas > >
