----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29102/#review65205 -----------------------------------------------------------
Ship it! Ship It! - Nate Cole On Dec. 16, 2014, 10:48 a.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29102/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2014, 10:48 a.m.) > > > Review request for Ambari and Nate Cole. > > > Bugs: AMBARI-8729 > https://issues.apache.org/jira/browse/AMBARI-8729 > > > Repository: ambari > > > Description > ------- > > 1) Add a property "units" to metric=type alert definitions, that can be used > for display. Try to stick to 3/4 chars in length. > 2) For metric=type alerts, add into about the thresholds to the descriptions > too. Like to the end: "The thresholds are in X units." > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/alert/Reporting.java > 6c937c2 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java > e94c012 > > Diff: https://reviews.apache.org/r/29102/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Jonathan Hurley > >
