[ 
https://issues.apache.org/jira/browse/AMBARI-8724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14249081#comment-14249081
 ] 

Jonathan Hurley commented on AMBARI-8724:
-----------------------------------------

+1 - I have comments b/c I'm confused and don't fully understand the system yet 
and want to make sure what I'm seeing isn't a boog.

{noformat}
-          <task xsi:type="execute">
+          <task xsi:type="execute" hosts="master">
{noformat}
- Can this be hosts="active" maybe? It's a little confusing; makes it seem like 
you're saying "Run it on all masters" when I think we're saying "Run it only on 
the main master (ignoring others in standby".

{noformat}
            // !!! revisit if needed
            if (hostsType.master != null && hostsType.secondary != null) {
{noformat}
- Should this be secondary? I would think that a secondary master (like 
Secondary NN) would not affect this task, but another standby master would

{noformat}
        if (execwrappers.size() > 0) {
          results.addAll(execwrappers);
{noformat}
- Change to !isEmpty() to appease the anti-size() gods?

> Rolling Upgrade - Upgrade Pack to restart standby ResourceManager first, 
> failover, and then upgrade the remaining RM
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: AMBARI-8724
>                 URL: https://issues.apache.org/jira/browse/AMBARI-8724
>             Project: Ambari
>          Issue Type: Technical task
>          Components: ambari-server
>    Affects Versions: 2.0.0
>            Reporter: Alejandro Fernandez
>            Assignee: Nate Cole
>             Fix For: 2.0.0
>
>         Attachments: AMBARI-8724.patch
>
>
> Runbook outlines that RM needs to first upgrade the standby, then failover to 
> make the upgrade standby the active, and then upgrade the RM that is now the 
> standby.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to