----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29052/#review65337 -----------------------------------------------------------
ambari-server/src/main/python/upgradeHelper.py <https://reviews.apache.org/r/29052/#comment108453> May need to wrap self.code with str(). ambari-server/src/main/python/upgradeHelper.py <https://reviews.apache.org/r/29052/#comment108454> May need to wrap self._version with str(). ambari-server/src/main/python/upgradeHelper.py <https://reviews.apache.org/r/29052/#comment108455> I suggest using, "with open(path, 'r') as f", or declaring f outside of the try statement as None, and then closing it in a finally block if the file handler is still open. +1 LGTM, may want to have someone else +1 since the number of lines is nontrivial. Nice feature! - Alejandro Fernandez On Dec. 17, 2014, 4:35 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29052/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2014, 4:35 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Mahadev Konar, Myroslav > Papirkovskyy, and Vitalyi Brodetskyi. > > > Bugs: AMBARI-8714 > https://issues.apache.org/jira/browse/AMBARI-8714 > > > Repository: ambari > > > Description > ------- > > Use upgradeHelper.py to allow adding new properties from 2.1/2.0 to 2.2 > upgrade. > this issue created as commit issue for trunk > > > Diffs > ----- > > ambari-server/src/main/python/UpgradeHelper_HDP2.py 396ec2b > ambari-server/src/main/python/upgradeHelper.py PRE-CREATION > > ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_1.3_to_2.2.json > PRE-CREATION > ambari-server/src/test/python/TestUpgradeHelper.py PRE-CREATION > ambari-server/src/test/python/TestUpgradeScript_HDP2.py 36ce54c > > Diff: https://reviews.apache.org/r/29052/diff/ > > > Testing > ------- > > [INFO] Ambari Views ...................................... SUCCESS [4.160s] > [INFO] Ambari Server ..................................... SUCCESS [27.432s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 32.198s > [INFO] Finished at: Mon Dec 15 19:27:28 FET 2014 > [INFO] Final Memory: 47M/408M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Dmitro Lisnichenko > >
