----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29206/#review65511 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java <https://reviews.apache.org/r/29206/#comment108718> The version may also be useful. I can do this in my patch. ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java <https://reviews.apache.org/r/29206/#comment108719> Nice! ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java <https://reviews.apache.org/r/29206/#comment108720> This should be called postTasksEffectiveHosts ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java <https://reviews.apache.org/r/29206/#comment108721> Are isServerAction and isCommand mutually exclusive? - Alejandro Fernandez On Dec. 18, 2014, 4:28 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29206/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2014, 4:28 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Jonathan Hurley. > > > Bugs: AMBARI-8796 > https://issues.apache.org/jira/browse/AMBARI-8796 > > > Repository: ambari > > > Description > ------- > > Fixes for manual and config tasks to be generated correctly out of the xml. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > c70a486 > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java > 15a730f > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java > 704851e > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java > c61dc1c > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java > 4a03ea0 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ManualTask.java > 1c06e7f > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServerSideActionTask.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapper.java > 0c4d363 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java > c1e65ca > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java > 7f5c298 > > ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java > 198191b > > ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_bucket_test.xml > PRE-CREATION > ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml > 70328ad > > Diff: https://reviews.apache.org/r/29206/diff/ > > > Testing > ------- > > pending > > > Thanks, > > Nate Cole > >
