----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29158/#review65543 -----------------------------------------------------------
ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py <https://reviews.apache.org/r/29158/#comment108769> If possible, used named imports instead of * ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py <https://reviews.apache.org/r/29158/#comment108765> More efficient to iterate key,value pairs in dictionary.iteritems() ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py <https://reviews.apache.org/r/29158/#comment108764> use default() since params may not have that property. ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py <https://reviews.apache.org/r/29158/#comment108766> Insert a space after the last colon. ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py <https://reviews.apache.org/r/29158/#comment108767> use OS.sep instead of "/" whenever possible ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py <https://reviews.apache.org/r/29158/#comment108768> Is it necessary to do a size check before attempting to get [:-4]? - Alejandro Fernandez On Dec. 18, 2014, 8:09 p.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29158/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2014, 8:09 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin > Jetly, Sid Wagle, and Yusaku Sako. > > > Bugs: AMBARI-8477 > https://issues.apache.org/jira/browse/AMBARI-8477 > > > Repository: ambari > > > Description > ------- > > The HDFS service components should indicate security state when queried by > Ambari Agent via STATUS_COMMAND. > > See https://issues.apache.org/jira/browse/AMBARI-8477 for more information. > > > Diffs > ----- > > ambari-agent/src/test/python/resource_management/TestSecurityCommons.py > PRE-CREATION > > ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py > 4afd4ce > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_client.py > b9f244a > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/journalnode.py > f664bcd > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/namenode.py > c8a460f > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/snamenode.py > 7106422 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/status_params.py > 0027a4c > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/zkfc_slave.py > ee8b418 > > Diff: https://reviews.apache.org/r/29158/diff/ > > > Testing > ------- > > Manual tests > Added > `ambari-agent/src/test/python/resource_management/TestSecurityCommons.py` - > test not executed on Jenkins(?) > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 40:45 min > [INFO] Finished at: 2014-12-17T00:43:24+00:00 > [INFO] Final Memory: 45M/523M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Robert Levas > >
