----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29235/#review65631 -----------------------------------------------------------
Ship it! Added a comment to point out that we won't be able to have client and server locations with this code simultaneously - but that should never be the case anyway, so +1 - nice and simple. ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params.py <https://reviews.apache.org/r/29235/#comment108856> Just so I understand the scenario here, it looks like this will start with the client library locations and then only override them if the command is for a server component. This works as long as we never need both the client directory and the server directory at the same time - which I think is the case anyway, so we're all good here. - Jonathan Hurley On Dec. 19, 2014, 8:14 a.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29235/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2014, 8:14 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Mahadev > Konar. > > > Bugs: AMBARI-8810 > https://issues.apache.org/jira/browse/AMBARI-8810 > > > Repository: ambari > > > Description > ------- > > HBase script changes and testing to make sure the correct commands are being > executed. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params.py > 79d47bf > ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py > 76bf82e > ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py > a38e2b8 > > ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_service_check.py > 1e6102a > ambari-server/src/test/python/stacks/2.0.6/configs/hbase-2.2.json > PRE-CREATION > ambari-server/src/test/python/stacks/2.0.6/configs/hbase-check-2.2.json > PRE-CREATION > ambari-server/src/test/python/stacks/2.0.6/configs/hbase-rs-2.2.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/29235/diff/ > > > Testing > ------- > > stack and server python changes: > > Total run:691 > Total errors:1 > Total failures:0 > OK > > (Just to clarify, the test failure is a known one and from OSX. Linux is > fine) > > > Thanks, > > Nate Cole > >
