-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29303/
-----------------------------------------------------------
Review request for Ambari, dilli dorai, Jaimin Jetly, John Speidel, Robert
Nettleton, and Yusaku Sako.
Bugs: AMBARI-8853
https://issues.apache.org/jira/browse/AMBARI-8853
Repository: ambari
Description
-------
Configuration keys in Kerberos descriptors should allow for variable
replacement. For example a typical `configurations` block may look like
```
"configurations" : [
"core-site": {
"hadoop.proxyuser.hive.groups":"${hadoop-env/proxyuser_group}"
},
"hive-site": {
.....
},
"webhcat-site": {
....
}
]
```
However some configuration keys need to be dynamically generated and should be
generated using the existing variable replacement feature in
`org.apache.ambari.server.state.kerberos.AbstractKerberosDescriptor`. For
example:
```
"configurations": [
"core-site": {
"hadoop.proxyuser.${hive-env/hive_user}.groups":"${hadoop-env/proxyuser_group}"
},
"hive-site": {
.....
},
"webhcat-site": {
....
}
]
```
The configuration key `hadoop.proxyuser.${hive-env/hive_user}.groups` should be
processed such that _${hive-env/hive_user}_ is replaced some value like `hive`
to yield `hadoop.proxyuser.hive.groups`
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
fb19bd5
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorTest.java
56f1a01
Diff: https://reviews.apache.org/r/29303/diff/
Testing
-------
Manual testing by visually watching the key being replaced in the debugger
while running in a test cluster
Unit test updated -
`org.apache.ambari.server.state.kerberos.KerberosDescriptorTest`
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.271 sec
Full ambari-server suite:
Tests run: 2447, Failures: 0, Errors: 0, Skipped: 13
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 40:39 min
[INFO] Finished at: 2014-12-22T06:52:37+00:00
[INFO] Final Memory: 44M/468M
[INFO] ------------------------------------------------------------------------
Thanks,
Robert Levas
