----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29309/#review65781 -----------------------------------------------------------
Ship it! Looks fine. - Robert Nettleton On Dec. 22, 2014, 2:30 p.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29309/ > ----------------------------------------------------------- > > (Updated Dec. 22, 2014, 2:30 p.m.) > > > Review request for Ambari, Jaimin Jetly, John Speidel, Robert Nettleton, and > Yusaku Sako. > > > Bugs: AMBARI-8855 > https://issues.apache.org/jira/browse/AMBARI-8855 > > > Repository: ambari > > > Description > ------- > > The Kerberos-related tasks show incorrect names in the UI ops list. More > friendly names should be displayed rather than 'Ambari Server Action Execute' > when displaying task list. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java > 4922fa5 > > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java > fb19bd5 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > fa39c97 > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java > a756275 > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java > 8ce4ff2 > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/ServerActionExecutorTest.java > 4bd0d18 > > Diff: https://reviews.apache.org/r/29309/diff/ > > > Testing > ------- > > Manually viewed fix in Ambari Web interface > > Ran unit tests > Tests run: 2447, Failures: 0, Errors: 0, Skipped: 13 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 40:35 min > [INFO] Finished at: 2014-12-22T13:10:34+00:00 > [INFO] Final Memory: 44M/522M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Robert Levas > >
