----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29323/#review65821 -----------------------------------------------------------
Ship it! Looks good. - Robert Nettleton On Dec. 22, 2014, 9:15 p.m., John Speidel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29323/ > ----------------------------------------------------------- > > (Updated Dec. 22, 2014, 9:15 p.m.) > > > Review request for Ambari, Jayush Luniya, Mahadev Konar, Robert Nettleton, > and Yusaku Sako. > > > Bugs: AMBARI-8867 > https://issues.apache.org/jira/browse/AMBARI-8867 > > > Repository: ambari > > > Description > ------- > > When creating a cluster via a blueprint, depending on the services being > deployed it is possible that the deployment will fail with "Unable to set > configurations on cluster". This is because we are trying to set set same > configuration on the cluster multiple times. This was a regression due to > changes in AMBARI-8561. > > This is likely a duplicate of AMBARI-8497 but I haven't tests with that BP > yet to confirm. > > This is a temporary fix specific to this issue. > The larger issue of specifying inter-service configuration dependencies in > the stack will be addressed separately. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java > f9aca1d > > Diff: https://reviews.apache.org/r/29323/diff/ > > > Testing > ------- > > Functional testing of BP associated with Jira. > In the process of running unit tests, will update with results. > > > Thanks, > > John Speidel > >
