----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29321/#review65835 -----------------------------------------------------------
Ship it! Ship It! - Jaimin Jetly On Dec. 22, 2014, 7:17 p.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29321/ > ----------------------------------------------------------- > > (Updated Dec. 22, 2014, 7:17 p.m.) > > > Review request for Ambari, John Speidel and Robert Nettleton. > > > Bugs: AMBARI-8860 > https://issues.apache.org/jira/browse/AMBARI-8860 > > > Repository: ambari > > > Description > ------- > > The _Update Service Configurations_ Kerberos task (implemented by > `org.apache.ambari.server.serveraction.kerberos.UpdateKerberosConfigsServerAction`) > fails when there is no work to do. This task should exit nicely if the data > file indicating the workload are not available since this tends to indicate > that there is no work to do. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerAction.java > a9dbbbd > > ambari-server/src/test/java/org/apache/ambari/server/agent/HeartBeatHandlerInjectKeytabTest.java > e6f48a1 > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerActionTest.java > 888a919 > > Diff: https://reviews.apache.org/r/29321/diff/ > > > Testing > ------- > > Manually ran scenarios on test cluster > > Added unit tests in > `org.apache.ambari.server.serveraction.kerberos.UpdateKerberosConfigsServerActionTest` > Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.533 sec > > Full Ambari server test suite > Tests run: 2449, Failures: 0, Errors: 0, Skipped: 13 > > > Thanks, > > Robert Levas > >
