----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29345/#review65853 -----------------------------------------------------------
Ship it! Ship It! - Yusaku Sako On Dec. 23, 2014, 12:59 a.m., Sid Wagle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29345/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2014, 12:59 a.m.) > > > Review request for Ambari, Mahadev Konar and Myroslav Papirkovskyy. > > > Bugs: AMBARI-8872 > https://issues.apache.org/jira/browse/AMBARI-8872 > > > Repository: ambari > > > Description > ------- > > - Ganglia supports point in time metrics along with time series data. > - Currently the provider module in the prototype does not send queries for > point in time metrics since timeline service does not support queries with > startTime and endTime = null. > - Add support to the timeline service for point in time querying. > > > Diffs > ----- > > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java > b5226ee > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixTransactSQL.java > fb02dc7 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricAggregator.java > cab154b > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricClusterAggregator.java > 654c188 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricClusterAggregatorHourly.java > 7764ea3 > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITClusterAggregator.java > f7e53f5 > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITMetricAggregator.java > d166a22 > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestPhoenixTransactSQL.java > 1659e46 > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java > 585a28c > > ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java > ae1e163 > > Diff: https://reviews.apache.org/r/29345/diff/ > > > Testing > ------- > > Unit tests passed. > > > Thanks, > > Sid Wagle > >
