----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29370/#review65941 -----------------------------------------------------------
The whole idea behind saving configs to disk was that they were quite large and we shouldn't keep them in-memory when we only needed a handful of them (comparatively). Can you do some proof-of-concept work to see how expensive it would be to keep them in-memory? My agents are currently running about 22-25m resident memory. If saving configs in-memory is a low-cost option, then we should just do that instead and not worry about all this de/serialization work for the config values. - Nate Cole On Dec. 23, 2014, 8:50 a.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29370/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2014, 8:50 a.m.) > > > Review request for Ambari and Jonathan Hurley. > > > Bugs: AMBARI-8885 > https://issues.apache.org/jira/browse/AMBARI-8885 > > > Repository: ambari > > > Description > ------- > > Looks like currently alerts use some sort of cached values. After enabling > security security_enabled value is false in alerts. After restarting agent it > changes to true. > Agent should not require restart after enabling security for alerts to work. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 19c1ee0 > ambari-agent/src/test/python/ambari_agent/TestAlerts.py 61473ec > > Diff: https://reviews.apache.org/r/29370/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
