----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29460/#review66379 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py <https://reviews.apache.org/r/29460/#comment109838> I recently did the rolling upgrade work for Hive. When executing the hiveserver2 start command, it returns immediately with an 0 error code. However, hive is actually still starting; that's why this check was put in. Hive does many asynchronous tasks during startup, including things like registering with ZooKeeper. Any of which could cause the startup to fail. By removing this code, we won't be able to accurately tell when the hiveserver2 has correctly started. In one instance during rolling upgrade, the hive server did fail to come up after 120 seconds if a certain error condition existed. By removing this check, it will also break rolling upgrades. Can you explain how we will properly detect hiveserver2's status? - Jonathan Hurley On Dec. 29, 2014, 12:05 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29460/ > ----------------------------------------------------------- > > (Updated Dec. 29, 2014, 12:05 p.m.) > > > Review request for Ambari and Dmytro Sen. > > > Bugs: AMBARI-8340 > https://issues.apache.org/jira/browse/AMBARI-8340 > > > Repository: ambari > > > Description > ------- > > <https://issues.apache.org/jira/browse/AMBARI-8227> > The fix was only applied to branch-1.7.0; needs to be applied on trunk. > Filed <https://issues.apache.org/jira/browse/AMBARI-8340> to keep track. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py > 3918a74 > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/hive_service.py > c68391a > ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_server.py 97c3fe8 > ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 8046313 > > Diff: https://reviews.apache.org/r/29460/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
