-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29563/
-----------------------------------------------------------

Review request for Ambari and Nate Cole.


Bugs: AMBARI-8982
    https://issues.apache.org/jira/browse/AMBARI-8982


Repository: ambari


Description
-------

Add support for summary renderers like ?format=groupedSummary to handle status 
when instances are in maintenance mode.

{code}
{
  "href" : 
"http://localhost:8080/api/v1/clusters/c1/alerts?format=groupedSummary&Alert/definition_id=6";,
  "alerts_summary_grouped" : [
    {
      "definition_id" : 6,
      "definition_name" : "falcon_server_webui",
      "summary" : {
        "OK" : {
          "count" : 0,
          "original_timestamp" : 1420061195766,
          "maintenance_count" : 1
        },
        "WARNING" : {
          "count" : 0,
          "original_timestamp" : 0,
          "maintenance_count" : 0
        },
        "CRITICAL" : {
          "count" : 0,
          "original_timestamp" : 0,
          "maintenance_count" : 0
        },
        "UNKNOWN" : {
          "count" : 0,
          "original_timestamp" : 0,
          "maintenance_count" : 0
        }
      }
    }
  ]
}
{code}

The status for an instance is still the status for that instance: crit, ok or 
warn. It's just whether that instance is in MM. 


Diffs
-----

  
ambari-server/src/main/java/org/apache/ambari/server/api/query/render/AlertSummaryGroupedRenderer.java
 52608b2 
  
ambari-server/src/main/java/org/apache/ambari/server/api/query/render/AlertSummaryRenderer.java
 48098e1 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java
 b339130 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertResourceProviderTest.java
 c1e7576 

Diff: https://reviews.apache.org/r/29563/diff/


Testing
-------

mvn clean test


Thanks,

Jonathan Hurley

Reply via email to