----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29580/#review66652 -----------------------------------------------------------
Ship it! Looks good. Please update the testing section before push. Thanks. - Tom Beerbower On Jan. 5, 2015, 11:32 a.m., Yurii Shylov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29580/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2015, 11:32 a.m.) > > > Review request for Ambari, Mahadev Konar, Sid Wagle, and Tom Beerbower. > > > Bugs: AMBARI-8984 > https://issues.apache.org/jira/browse/AMBARI-8984 > > > Repository: ambari > > > Description > ------- > > Ambari LDAP sync does not work with AD where uid is set to null. > > Steps to reproduce: > > Try syncing ldap users from AD and you will see messages like: > > 17:19:42,915 WARN [pool-1-thread-1] AmbariLdapDataPopulator:560 - Ignoring > LDAP user cn=Ambari Admin,ou=Ambari,dc=SME,dc=support,dc=com as it doesn't > have required attributes uid and sAMAccountName > 17:20:38,375 WARN [pool-1-thread-2] AmbariLdapDataPopulator:560 - Ignoring > LDAP user cn=testUser,ou=Ambari,dc=SME,dc=support,dc=com as it doesn't have > required attributes uid and sAMAccountName > 17:21:47,387 WARN [pool-1-thread-3] AmbariLdapDataPopulator:560 - Ignoring > LDAP user cn=testUser,ou=Ambari,dc=SME,dc=support,dc=com as it doesn't have > required attributes uid and sAMAccountName > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 4bbe255 > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/LdapServerProperties.java > 758523b > > ambari-server/src/main/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulator.java > 62e2966 > ambari-server/src/main/python/ambari-server.py 49f3f2c > > ambari-server/src/test/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulatorTest.java > fc399ac > ambari-server/src/test/python/TestAmbariServer.py 0eae33b > > Diff: https://reviews.apache.org/r/29580/diff/ > > > Testing > ------- > > In progress > > > Thanks, > > Yurii Shylov > >
