----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29555/#review66710 -----------------------------------------------------------
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsListCtrl.js <https://reviews.apache.org/r/29555/#comment110291> No need to load all data when page changed if we use client side pagination, In general better to create separate ticket to move pagination on client side and use pagination and filtering on one side client or server, otherwise it becomes confusing,comprehensive and hard to maintenance - Andrii Tkach On Янв. 3, 2015, 2:18 д.п., Richard Zang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29555/ > ----------------------------------------------------------- > > (Updated Янв. 3, 2015, 2:18 д.п.) > > > Review request for Ambari, Andriy Babiichuk, Andrii Tkach, and Yusaku Sako. > > > Bugs: AMBARI-8981 > https://issues.apache.org/jira/browse/AMBARI-8981 > > > Repository: ambari > > > Description > ------- > > Do not allow deregistering when repo version's current/installed. > Fix repo version listing page pagination. > Some code refactor on listing controller. > > > Diffs > ----- > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js > e951c97 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsListCtrl.js > 0744a9a > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Cluster.js > a0e4ab6 > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js > 4e93854 > > ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/list.html > ef15f1d > > Diff: https://reviews.apache.org/r/29555/diff/ > > > Testing > ------- > > Manually tested in live cluster. All unit tests successfully passed. > > > Thanks, > > Richard Zang > >
