----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29638/#review66924 -----------------------------------------------------------
Ship it! Looks good. - Robert Nettleton On Jan. 6, 2015, 8:59 p.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29638/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2015, 8:59 p.m.) > > > Review request for Ambari, John Speidel and Robert Nettleton. > > > Bugs: AMBARI-9006 > https://issues.apache.org/jira/browse/AMBARI-9006 > > > Repository: ambari > > > Description > ------- > > Variable replacement fails for some (complicated) values in > {{org.apache.ambari.server.state.kerberos.AbstractKerberosDescriptor#replaceVariables}}. > > For example > ``` > hive.metastore.local=false,hive.metastore.uris=thrift://${host}:9083,hive.metastore.sasl.enabled=true,hive.metastore.execute.setugi=true,hive.metastore.warehouse.dir=/apps/hive/warehouse,hive.exec.mode.local.auto=false,hive.metastore.kerberos.principal=hive/_HOST@${realm} > ``` > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptor.java > cd44fe5 > > ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorTest.java > 3b201b6 > > Diff: https://reviews.apache.org/r/29638/diff/ > > > Testing > ------- > > #Jenkins Test Results > Running org.apache.ambari.server.state.kerberos.KerberosDescriptorTest > Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.275 sec > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 01:05 h > [INFO] Finished at: 2015-01-06T20:32:34+00:00 > [INFO] Final Memory: 44M/537M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Robert Levas > >
