> On Jan. 8, 2015, 9:17 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/python/ambari_server/serverSetup.py, line 333 > > <https://reviews.apache.org/r/29713/diff/1/?file=813305#file813305line333> > > > > Should this use a delimitter between the family and version?
So far there was no sign of such a thing. The code is identical to the one in ambari-server.py. - Florian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29713/#review67296 ----------------------------------------------------------- On Jan. 8, 2015, 5:02 p.m., Florian Barca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29713/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2015, 5:02 p.m.) > > > Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Jayush Luniya, > and Mahadev Konar. > > > Bugs: AMBARI-9038 > https://issues.apache.org/jira/browse/AMBARI-9038 > > > Repository: ambari > > > Description > ------- > > Added the missing setting required for the OS detection to work properly > > > Diffs > ----- > > ambari-server/src/main/python/ambari_server/serverConfiguration.py > aab116711219f633e3a1a6328d80e9ec68308d15 > ambari-server/src/main/python/ambari_server/serverSetup.py > 37e46f5a480a6186a42a49ce64637da76b133b48 > ambari-server/src/test/python/TestAmbariServer.py > 9290558c6e7f155203c3c9e1ef8acc729779521f > > Diff: https://reviews.apache.org/r/29713/diff/ > > > Testing > ------- > > mvn clean test -> ambari-server setup -> cluster deployment -> reload ok > > > Thanks, > > Florian Barca > >
