> On Jan. 9, 2015, 11:49 a.m., Nate Cole wrote: > > ambari-server/src/test/python/custom_actions/TestInstallPackages.py, lines > > 59-60 > > <https://reviews.apache.org/r/29767/diff/1/?file=814413#file814413line59> > > > > Strange that you don't need the u' here for repo_template, but you do > > in the other test methods that do the same check.
I thought so as well. I did double check that b.a.o was seeing similar errors: ``` + 'repo_file_name': u'HDP-2.2.0.1-885', ``` I honestly don't understand why our comparisons don't take into account unicode vs non-unicode encoded strings. But my goal here wasn't to rewrite the test framework, just to get to the point where I can continue my own work and see correct results from the tests. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29767/#review67448 ----------------------------------------------------------- On Jan. 9, 2015, 11:30 a.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29767/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2015, 11:30 a.m.) > > > Review request for Ambari, Nate Cole and Tom Beerbower. > > > Bugs: AMBARI-9063 > https://issues.apache.org/jira/browse/AMBARI-9063 > > > Repository: ambari > > > Description > ------- > > The Ambari builds are succeeding locally and on builds.apache.org even though > the trunk currently has failures on python tests. See > > https://builds.apache.org/view/All/job/Ambari-trunk-Commit/1441/consoleFull > > And search for "Total run:570" > > It looks like the root cause of this is that the python test runner is > reporting an OK with failures: > > {noformat} > $ python unitTests.py > ... > > ---------------------------------------------------------------------- > Total run:569 > Total errors:0 > Total failures:4 > OK > {noformat} > > The problem is that the python test runner is reporting a success: > {code} > tests_status = textRunner.wasSuccessful() and not has_failures > {code} > > {code} > print textRunner.wasSuccessful() > True > > print has_failures > False > {code} > > > Diffs > ----- > > ambari-server/src/test/python/custom_actions/TestCheckHost.py cb934c9 > ambari-server/src/test/python/custom_actions/TestInstallPackages.py beb918b > ambari-server/src/test/python/unitTests.py 7c9f089 > > Diff: https://reviews.apache.org/r/29767/diff/ > > > Testing > ------- > > OK > ---------------------------------------------------------------------- > Total run:570 > Total errors:0 > Total failures:0 > OK > > Verified that causing tests to fail in ambari-server and custom-actions > causes the build to fail as well. > > > Thanks, > > Jonathan Hurley > >
