> On Jan. 9, 2015, 1:18 p.m., Nate Cole wrote:
> > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py,
> >  lines 71-72
> > <https://reviews.apache.org/r/29769/diff/1/?file=814723#file814723line71>
> >
> >     Where in the world did this come from?!  I hope it's doc'ed somewhere.  
> > On my deployment /usr/bin/oozie is symlinked to 
> > /usr/hdp/current/oozie-client/bin/oozie

Oozie is not documented at all :)

This is a valid step, however, and I have confirmed that the link is recreated 
after the upgrade is done.


> On Jan. 9, 2015, 1:18 p.m., Nate Cole wrote:
> > ambari-server/src/test/python/stacks/2.2/configs/oozie-upgrade.json, lines 
> > 1-4
> > <https://reviews.apache.org/r/29769/diff/1/?file=814728#file814728line1>
> >
> >     Nit: I usually remove all the configs that aren't the one I'm testing.  
> > It takes the file from a thousand to about 150 lines.

Good point - more toiling in test land for me. I will update the patch.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29769/#review67464
-----------------------------------------------------------


On Jan. 9, 2015, 1:08 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29769/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2015, 1:08 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
> 
> 
> Bugs: AMBARI-9072
>     https://issues.apache.org/jira/browse/AMBARI-9072
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Create the HDP upgrade pack for Oozie according to the runbook. The following 
> steps will be performed:
> 
> - Backup and restoration of Oozie configuration files
> - Backup of Oozie database
> - Installation of a new sharelib in HDFS
> - Preparation of the new Oozie WAR
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py
>  a7313f3 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
>  a129bce 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py
>  59966fd 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params.py
>  57ea5c1 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 
> ed6b50c 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 
> 4324040 
>   ambari-server/src/test/python/stacks/2.2/configs/oozie-upgrade.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/29769/diff/
> 
> 
> Testing
> -------
> 
> OK
> ----------------------------------------------------------------------
> Total run:572
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Reply via email to