----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29824/ -----------------------------------------------------------
Review request for Ambari, John Speidel, Robert Levas, and Tom Beerbower. Repository: ambari Description ------- This patch implements a fix for AMBARI-9097. Falcon deployments are not currently working with Blueprints. The ClusterResourceProvider is not currently handling the case of a Falcon Blueprints deployment, with respect to configuration handling. A portion of the changes from the fix for AMBARI-8009 originally addressed this problem by adding some code to filter out the "excluded" configuration references for a given stack service, since only included config references should be used during a cluster configuration update. Some code refactorings in the patch for AMBARI-7175 moved the filtering code to a separate location, and this eventually resulted in a breakage, since some components seem to interpret "excluded" configuration references differently. To resolve this issue, this current patch implements the following: - Re-introduces some of the changes from AMBARI-8009 that were removed by subsequent refactorings. These changes modify the ClusterResourceProvider's setConfigurationsOnCluster() method, so that excluded configuration references are not included for a given service's config change request. - Implements new unit tests to verify this change. - Updates some existing unit tests to reflect the changes to the Stack class. Diffs ----- ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java 0eecb3f ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java 2d6ad8f ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Stack.java 243e282 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java c620bc6 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java bc2fc02 Diff: https://reviews.apache.org/r/29824/diff/ Testing ------- 1. Ran ambari-server unit tests, all Java tests passing. Some python failures, but these are due to a separate problem currently being addressed in the codebase. 2. Manually verified that applying this patch will fix Falcon Blueprints deployments in single-node and multi-node clusters. Thanks, Robert Nettleton
