----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29701/#review67870 -----------------------------------------------------------
Ship it! Ship It! - John Speidel On Jan. 13, 2015, 2:11 a.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29701/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2015, 2:11 a.m.) > > > Review request for Ambari, Jaimin Jetly, John Speidel, Nate Cole, and Robert > Nettleton. > > > Bugs: AMBARI-9014 > https://issues.apache.org/jira/browse/AMBARI-9014 > > > Repository: ambari > > > Description > ------- > > Provide the standard error code that will be returned along with the error > message. > > If administrative credentials are not available > ``` > { > "status" : 400, > "message" : "java.lang.IllegalArgumentException: Missing KDC administrator > credentials.\nThe KDC administrator credentials must be set in session by > updating the relevant Cluster resource.This may be done by issuing a PUT to > the api/v1/clusters/(cluster name) API entry point with the following > payload:\n{\n \"session_attributes\" : {\n \"kerberos_admin\" : > {\"principal\" : \"(PRINCIPAL)\", \"password\" : \"(PASSWORD)\"}\n }\n}" > } > ``` > > If administrative credentials are not valid, for example, incorrect principal > or password (or keytab) > ``` > { > "status" : 400, > "message" : "java.lang.IllegalArgumentException: Invalid KDC administrator > credentials.\nThe KDC administrator credentials must be set in session by > updating the relevant Cluster resource.This may be done by issuing a PUT to > the api/v1/clusters/(cluster name) API entry point with the following > payload:\n{\n \"session_attributes\" : {\n \"kerberos_admin\" : > {\"principal\" : \"(PRINCIPAL)\", \"password\" : \"(PASSWORD)\"}\n }\n}" > } > ``` > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java > 9662669 > > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java > 0533228 > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandler.java > a8eed2b > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java > be70ba1 > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java > a6392da > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosAdminAuthenticationException.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosKDCConnectionException.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosLDAPContainerException.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationException.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java > ae2d4b2 > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerFactory.java > 30e3c35 > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosRealmException.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java > a99628c > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java > 04d43a5 > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/TrustingSSLSocketFactory.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java > 8f39f21 > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandlerTest.java > 9f0e7ed > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/AbstractKerberosOperationHandlerTest.java > 92a4100 > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerFactoryTest.java > 4c7e49d > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerTest.java > 72d58e2 > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java > b61b76f > > Diff: https://reviews.apache.org/r/29701/diff/ > > > Testing > ------- > > Manaully tested in test cluster > > #Jenkins Test Results > > Running org.apache.ambari.server.controller.KerberosHelperTest > Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.632 sec > > Running org.apache.ambari.server.stack.KerberosDescriptorTest > Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.19 sec > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 01:00 h > [INFO] Finished at: 2015-01-08T04:22:16+00:00 > [INFO] Final Memory: 44M/513M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Robert Levas > >
