> On Jan. 13, 2015, 11:21 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java, > > lines 551-554 > > <https://reviews.apache.org/r/29864/diff/1/?file=819857#file819857line551> > > > > @Transactional for a get? Or are you trying to prevent a concurrent > > update to the entity?
Thanks for the review. Yeah, I don't like this. I want to get a detached entity. There should be a better way. I'll change this. - Tom ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29864/#review67969 ----------------------------------------------------------- On Jan. 13, 2015, 8:51 p.m., Tom Beerbower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29864/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2015, 8:51 p.m.) > > > Review request for Ambari and Nate Cole. > > > Bugs: AMBARI-9112 > https://issues.apache.org/jira/browse/AMBARI-9112 > > > Repository: ambari > > > Description > ------- > > An invalid property supplied for an update is rejected by the validator but > the view registry local copy of the view instance entity is updated with the > bogus value. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java > 12a8bee > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java > dd7417a > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java > 57a05f1 > > ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java > 26a9b36 > > Diff: https://reviews.apache.org/r/29864/diff/ > > > Testing > ------- > > Manual tests. New unit tests added. All tests pass ... > > Results : > > Tests run: 2507, Failures: 0, Errors: 0, Skipped: 13 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 28:03 min > [INFO] Finished at: 2015-01-13T15:22:29-05:00 > [INFO] Final Memory: 42M/527M > [INFO] > ------------------------------------------------------------------------ > [INFO] Final Memory: 42M/601M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Tom Beerbower > >
