----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29790/#review68146 -----------------------------------------------------------
Ship it! I think there are issues with hdp-select hadoop-client running on machines where other components/clients have not actually been updated yet. However, I don't see a way around this exception to just do all of the work at the end in the clients grouping. That Jira has already been filed. - Jonathan Hurley On Jan. 14, 2015, 4:45 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29790/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2015, 4:45 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Mahadev > Konar, Nate Cole, and Yurii Shylov. > > > Bugs: AMBARI-9081 > https://issues.apache.org/jira/browse/AMBARI-9081 > > > Repository: ambari > > > Description > ------- > > See AMBARI-8995, after that changes master components have their version in > the results of START command, but clients do not execute this command and > thus it's not possible to track their new version. As the result some > components of the cluster remain in non upgraded state and it prevents from > setting cluster to upgraded state and finalize upgrade. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/PythonExecutor.py 76ba1c6 > ambari-agent/src/test/python/resource_management/TestScript.py bff04b4 > ambari-common/src/main/python/resource_management/libraries/script/hook.py > 5c8eafc > > ambari-common/src/main/python/resource_management/libraries/script/script.py > af02f37 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py > 5c430df > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py > 6f37f50 > > ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py > 59dba8d > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py > 3f19ce4 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py > d54ecb9 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py > 72b657f > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py > 50bd822 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py > 59be175 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py > 6d8716f > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py > 7b171a8 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py > a625295 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py > 5fc27f4 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py > a11a0b6 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py > 568ee8e > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py > 546afca > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py > 878b50c > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py > ecd41c5 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py > 660a630 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py > 9a3eb66 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py > a43bda5 > > ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params.py > d7bf5eb > > ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py > 2dd3835 > > ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider_client.py > 33b68c7 > > ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/service_check.py > 33ced03 > > ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop_client.py > db8f188 > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py > 4b11b82 > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py > f70f67b > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py > ef8b95e > > ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params.py > 13ab77f > > ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py > 04cfb90 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py > a8ead39 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py > 4c450ef > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py > c4e2800 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py > 78a75f6 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py > 2b8c631 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py > 60b9bce > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py > 7d57983 > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py > 626ceba > > Diff: https://reviews.apache.org/r/29790/diff/ > > > Testing > ------- > > Copied files to a cluster, and verified that restarting the services showed > the version in structured_out of the host_role_command table. > > ``` > ambari=> select task_id, host_name, status, role, role_command, > custom_command_name, structured_out from host_role_command where task_id >= > 104 order by task_id ASC; > task_id | host_name | status | role | > role_command | custom_command_name | structured_out > ---------+-------------------------+-----------+----------------------+----------------+---------------------+----------------------------- > 104 | c6405.ambari.apache.org | COMPLETED | FALCON_CLIENT | > INSTALL | | {"version": "2.2.1.0-2205"} > 105 | c6406.ambari.apache.org | COMPLETED | FALCON_CLIENT | > INSTALL | | {"version": "2.2.1.0-2205"} > 106 | c6406.ambari.apache.org | COMPLETED | FALCON_SERVER | > INSTALL | | {"version": "2.2.1.0-2205"} > 107 | c6407.ambari.apache.org | COMPLETED | FALCON_CLIENT | > INSTALL | | {"version": "2.2.1.0-2205"} > 108 | c6406.ambari.apache.org | COMPLETED | FALCON_SERVER | START > | | {"version": "2.2.1.0-2205"} > 109 | c6407.ambari.apache.org | COMPLETED | FALCON_SERVICE_CHECK | > SERVICE_CHECK | | {} > 110 | c6405.ambari.apache.org | COMPLETED | HBASE_CLIENT | > CUSTOM_COMMAND | RESTART | {"version": "2.2.1.0-2205"} > 111 | c6405.ambari.apache.org | COMPLETED | HBASE_MASTER | > CUSTOM_COMMAND | RESTART | {"version": "2.2.1.0-2205"} > 112 | c6405.ambari.apache.org | COMPLETED | HBASE_REGIONSERVER | > CUSTOM_COMMAND | RESTART | {"version": "2.2.1.0-2205"} > 113 | c6406.ambari.apache.org | COMPLETED | HBASE_CLIENT | > CUSTOM_COMMAND | RESTART | {"version": "2.2.1.0-2205"} > 114 | c6406.ambari.apache.org | COMPLETED | HBASE_REGIONSERVER | > CUSTOM_COMMAND | RESTART | {"version": "2.2.1.0-2205"} > 115 | c6407.ambari.apache.org | COMPLETED | HBASE_CLIENT | > CUSTOM_COMMAND | RESTART | {"version": "2.2.1.0-2205"} > 116 | c6406.ambari.apache.org | COMPLETED | DRPC_SERVER | > INSTALL | | {"version": "2.2.1.0-2205"} > 117 | c6406.ambari.apache.org | COMPLETED | NIMBUS | > INSTALL | | {"version": "2.2.1.0-2205"} > 118 | c6406.ambari.apache.org | COMPLETED | STORM_UI_SERVER | > INSTALL | | {"version": "2.2.1.0-2205"} > 119 | c6407.ambari.apache.org | COMPLETED | SUPERVISOR | > INSTALL | | {"version": "2.2.1.0-2205"} > 120 | c6406.ambari.apache.org | COMPLETED | NIMBUS | START > | | {"version": "2.2.1.0-2205"} > 121 | c6406.ambari.apache.org | COMPLETED | DRPC_SERVER | START > | | {"version": "2.2.1.0-2205"} > 122 | c6406.ambari.apache.org | COMPLETED | STORM_UI_SERVER | START > | | {"version": "2.2.1.0-2205"} > 123 | c6407.ambari.apache.org | COMPLETED | SUPERVISOR | START > | | {"version": "2.2.1.0-2205"} > 124 | c6406.ambari.apache.org | COMPLETED | STORM_SERVICE_CHECK | > SERVICE_CHECK | | {} > (21 rows) > ``` > > mvn clean test > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 30:31.481s > [INFO] Finished at: Mon Jan 12 13:23:01 PST 2015 > [INFO] Final Memory: 66M/721M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Alejandro Fernandez > >
