----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29914/ -----------------------------------------------------------
Review request for Ambari, John Speidel and Robert Levas. Repository: ambari Description ------- Blueprints that included Kafka, but not Ganglia, were failing due to an issue in the BlueprintConfigurationProcessor. The BlueprintConfigurationProcessor was failing during an attempt to perform hostname substitution on a kafka-broker property, which is mapped to the GANGLIA_SERVER's hostname. If GANGLIA_SERVER is not included in the cluster, the Blueprint deployment will fail. This patch addresses this issue by: - Modifying the property updater registration for the kafka property that is mapped to the GANGLIA_SERVER component, such that the property will use hostname substitution when Ganglia is present, and will return the original stack-defined value when Ganglia is not present in the cluster. - Adds assertions to some existing unit tests to verify that this Kafka configuration property is handled correctly in the cases of when Ganglia is or is not present in the cluster. Diffs ----- ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java d7b4498 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java 167e8fa Diff: https://reviews.apache.org/r/29914/diff/ Testing ------- 1. Ran the ambari-server unit tests (all passing). 2. Manually verified that a Blueprint deployment of a cluster that includes Kafka, but not Ganglia, will succeed. Thanks, Robert Nettleton
