> On Янв. 16, 2015, 6:46 п.п., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java, > > line 1377 > > <https://reviews.apache.org/r/29969/diff/1/?file=823592#file823592line1377> > > > > We should not allow creating a new cluster_version in an installing > > state.
These two issues are basically the same. When we get the first successfully installed service, we should update the host version state and the cluster version, so at that moment there should be only one cluster_version in INSTALLING state. This is not supported right now and causes some side effects, so I've decided to make it CURRENT from the very beginning and treat it as technical debt. Previously cluster version was assumed as CURRENT even before the first component was upgraded. - Yurii ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29969/#review68445 ----------------------------------------------------------- On Янв. 16, 2015, 6:26 п.п., Yurii Shylov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29969/ > ----------------------------------------------------------- > > (Updated Янв. 16, 2015, 6:26 п.п.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate > Cole. > > > Bugs: AMBARI-9183 > https://issues.apache.org/jira/browse/AMBARI-9183 > > > Repository: ambari > > > Description > ------- > > Currently on clean install Ambari creates cluster entity and its repository > version with version taken from selected stack. I.e. for stack HDP-2.2, > version 2.2 is written to database, without any information about the actual > minor version of that stack. Besides that we can't assume that cluster has > some version until it has at least one of components of that version. > Repository version creation should be detached from cluster creation; instead > of that versions should be created after receiving the first actual version > from service responses during install. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java > b5fda49 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 6dabcbb > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 9b17b33 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > 19a5f9f > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java > 9ec8c36 > > ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java > 31606ca > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java > 57c0223 > > Diff: https://reviews.apache.org/r/29969/diff/ > > > Testing > ------- > > In progress > > Manual testing was performed on 3-node cluster > > > Thanks, > > Yurii Shylov > >
