-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30028/
-----------------------------------------------------------
Review request for Ambari, Jaimin Jetly, John Speidel, Robert Nettleton, and
Tom Beerbower.
Bugs: AMBARI-9170
https://issues.apache.org/jira/browse/AMBARI-9170
Repository: ambari
Description
-------
The properties used to create accounts in an Active Directory, related to
principal creation, should be configurable such that a user may specify the
required fields and their values (with variable replacement).
This may be done using a simple structure like XML or JSON, however a template
facility (like _Velocity_) may be more useful since conditional paths may be
built in. The template should be stored in the `kerberos-env` configuration.
An example of a need for a conditional path in a template is related to
_service_ accounts vs _user_ accounts. A _service_ account (such as
nn/_HOST@REALM) should have the `servicePrincipalName` field set to the
service's principal, where this value shouldn't be set for a _user_ account
(such as hdfs@REALM).
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java
f0e4e9c
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
6d0e159
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
befd014
ambari-server/src/main/java/org/apache/ambari/server/serveraction/AbstractServerAction.java
9882e73
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandler.java
dce980d
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java
49f573e
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java
b3592e6
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java
23eed35
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java
e2e8c09
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
0ecf6c0
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java
2e79741
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java
c3418dc
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
8900a26
ambari-server/src/test/java/org/apache/ambari/server/serveraction/ServerActionExecutorTest.java
73f7be7
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandlerTest.java
aad325a
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerTest.java
40686d6
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java
5d72585
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java
bd0e938
Diff: https://reviews.apache.org/r/30028/diff/
Testing
-------
Manual testing in test cluster
Updated unit tests
#Jenkins Results
Running
org.apache.ambari.server.serveraction.kerberos.ADKerberosOperationHandlerTest
Tests run: 10, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.711 sec
Running
org.apache.ambari.server.serveraction.kerberos.MITKerberosOperationHandlerTest
Tests run: 9, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.422 sec
Running org.apache.ambari.server.serveraction.kerberos.KerberosServerActionTest
Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.167 sec
Running
org.apache.ambari.server.serveraction.kerberos.MITKerberosOperationHandlerTest
Tests run: 9, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.422 sec
Running org.apache.ambari.server.serveraction.ServerActionExecutorTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.761 sec
Full ambari-server test suite
Tests run: 2548, Failures: 0, Errors: 0, Skipped: 15
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:00 h
[INFO] Finished at: 2015-01-19T13:30:31+00:00
[INFO] Final Memory: 43M/531M
[INFO] ------------------------------------------------------------------------
Thanks,
Robert Levas
