[
https://issues.apache.org/jira/browse/AMBARI-9102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14282571#comment-14282571
]
Hadoop QA commented on AMBARI-9102:
-----------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12693085/AMBARI-9102_01.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
ambari-server.
Test results:
https://builds.apache.org/job/Ambari-trunk-test-patch/1383//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/1383//console
This message is automatically generated.
> Refactor rolling upgrades prerequisite checks to expose and repackage utility
> classes
> -------------------------------------------------------------------------------------
>
> Key: AMBARI-9102
> URL: https://issues.apache.org/jira/browse/AMBARI-9102
> Project: Ambari
> Issue Type: Improvement
> Components: ambari-server
> Affects Versions: 2.0.0
> Reporter: Robert Levas
> Assignee: Robert Levas
> Fix For: 2.0.0
>
> Attachments: AMBARI-9102_01.patch
>
>
> The logic in the org.apache.ambari.server.state.UpgradeCheckHelper should be
> exposed so that resources may use it.
> The following steps will be taken:
> * Move the static classes out of
> {{org.apache.ambari.server.state.UpgradeCheckHelper}} and into a package
> named {{org.apache.ambari.server.checks}}
> * Rename {{UpgradeCheckDescriptor}} to {{AbstractCheckDescriptor}}
> * Create {{org.apache.ambari.server.checks.CheckHelper}} and move
> {{org.apache.ambari.server.state.UpgradeCheckHelper#performPreUpgradeChecks}}
> into it
> * Adjust
> {{org.apache.ambari.server.controller.internal.PreUpgradeCheckResourceProvider}}
> accordingly
> * {{UpgradeCheckRequest}}, {{UpgradeCheck}} and other similar resources which
> encapsulate check data will be generalized to {{PrereqCheckRequest}} ,
> {{PrerequisiteCheck}} and so on
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
