----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30099/#review68809 -----------------------------------------------------------
Ship it! Ship It! - Robert Levas On Jan. 20, 2015, 5:45 p.m., Robert Nettleton wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30099/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2015, 5:45 p.m.) > > > Review request for Ambari, John Speidel and Robert Levas. > > > Repository: ambari > > > Description > ------- > > This patch resolves AMBARI-9223. > > The ClusterBlueprintRenderer has been modified to obtain the > "properties_attributes" associated with each configuration > type from the Cluster resource, and to include these > attributes in the Blueprint resource that is created > during the export process. > > A new unit test has been added to verify this change. > > This patch also addresses a minor problem in the > BlueprintConfigurationProcessor that was found while > testing the fix for this patch. In addition to this > minor fix, new unit test assertions have been added > to verify this change. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRenderer.java > a584490 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > 8f84f62 > > ambari-server/src/test/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRendererTest.java > 61ea1ad > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java > c8d1214 > > Diff: https://reviews.apache.org/r/30099/diff/ > > > Testing > ------- > > 1. Run the ambari-server unit tests, all passing ("Tests run: 2567, Failures: > 0, Errors: 0, Skipped: 15"). > 2. Manually verified that properties declared as "final" in a cluster started > by the UI are also declared as "final" in a Blueprint exported from this > cluster. > 3. Took the exported Blueprint in Step #2, and verified that I can deploy a > cluster based on this Blueprint, and that the expected properties are marked > as "final" in the Ambari UI once the cluster deployment completes. > > > Thanks, > > Robert Nettleton > >
