> On Jan. 21, 2015, 8:19 p.m., Robert Nettleton wrote: > > ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestBody.java, > > line 154 > > <https://reviews.apache.org/r/30132/diff/1/?file=828581#file828581line154> > > > > Minor issue: > > > > Shouldn't "RAW_REQUEST_BODY" be replaced with the constant defined in > > the Request class in this patch?
I was going to do so but the package that contains RequestBody is an api package and we don't want the api packages reaching down into the internal server packages. So there currently isn't a good place to put a constant that could be used by both packages. - John ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30132/#review68994 ----------------------------------------------------------- On Jan. 21, 2015, 6:28 p.m., John Speidel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30132/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 6:28 p.m.) > > > Review request for Ambari, Jaimin Jetly, Robert Nettleton, and Tom Beerbower. > > > Bugs: AMBARI-9243 > https://issues.apache.org/jira/browse/AMBARI-9243 > > > Repository: ambari > > > Description > ------- > > When an artifact resource is created with a nested map structure, the json > representation of the resource flattens out the property names instead of > preserving the original hierarchy. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestBody.java > f4c5647 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ArtifactResourceProvider.java > b3eb159 > > ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Request.java > f937a4c > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ArtifactResourceProviderTest.java > 4ed1a51 > > Diff: https://reviews.apache.org/r/30132/diff/ > > > Testing > ------- > > Functional tests using nexted artifact data. > Unit Tests: > All existing pass. > Added new unit tests for this scenario. > > > Thanks, > > John Speidel > >
