> On Jan. 21, 2015, 9:30 p.m., Nate Cole wrote: > > ambari-agent/src/main/python/ambari_agent/HostCleanup.py, line 93 > > <https://reviews.apache.org/r/30136/diff/3/?file=828835#file828835line93> > > > > Probably should calculate this out of ambari-agent.ini. The agent > > section has a key, "prefix" that can be used.
Stack scripts have no direct access to ambari-agent.ini. Moreover, ini file parsing is built into ambari-agent code. I think it would be an overkill - Dmitro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30136/#review69016 ----------------------------------------------------------- On Jan. 21, 2015, 9:18 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30136/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 9:18 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Nate Cole, Tom Beerbower, and > Yurii Shylov. > > > Bugs: AMBARI-9248 > https://issues.apache.org/jira/browse/AMBARI-9248 > > > Repository: ambari > > > Description > ------- > > There's a post-install hook to perform hdp-select. This has erroneous logic > and sets the /usr/hdp/current version to the latest installed > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/HostCleanup.py 7aeb70a > ambari-agent/src/test/python/ambari_agent/TestHostCleanup.py 84b96cc > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py > f256688 > > Diff: https://reviews.apache.org/r/30136/diff/ > > > Testing > ------- > > Short manual check to ensure that fix behaves as intended. Now conducting a > full-pledged deployment to see all effects > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Views ...................................... SUCCESS [2.865s] > [INFO] Ambari Server ..................................... SUCCESS [35.053s] > [INFO] Ambari Agent ...................................... SUCCESS [6.128s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 44.924s > [INFO] Finished at: Wed Jan 21 23:27:12 FET 2015 > [INFO] Final Memory: 41M/353M > > > Thanks, > > Dmitro Lisnichenko > >
