----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30166/#review69201 -----------------------------------------------------------
Ship it! Ship It! - Sid Wagle On Jan. 22, 2015, 1:25 p.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30166/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2015, 1:25 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko and Myroslav Papirkovskyy. > > > Bugs: AMBARI-9262 > https://issues.apache.org/jira/browse/AMBARI-9262 > > > Repository: ambari > > > Description > ------- > > Metrics system got in a bad state so ambari server was unable to retrieve > metrics. exceptions were bring printed to the ambari-server log, even though, > the message is warn. > Should avoid printing stack trace to log unless in DEBUG. This log entry > should be an error > 09:59:48,274 WARN [qtp170173019-19] MetricsPropertyProvider:187 - Error > getting timeline metrics. > java.net.SocketTimeoutException: Read timed out > at java.net.SocketInputStream.socketRead0(Native Method) > at java.net.SocketInputStream.read(SocketInputStream.java:152) > at java.net.SocketInputStream.read(SocketInputStream.java:122) > at java.io.BufferedInputStream.fill(BufferedInputStream.java:235) > at java.io.BufferedInputStream.read1(BufferedInputStream.java:275) > at java.io.BufferedInputStream.read(BufferedInputStream.java:334) > at sun.net.www.http.HttpClient.parseHTTPHeader(HttpClient.java:687) > at sun.net.www.http.HttpClient.parseHTTP(HttpClient.java:633) > at > sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1323) > at > java.net.HttpURLConnection.getResponseCode(HttpURLConnection.java:468) > at > org.apache.ambari.server.controller.internal.URLStreamProvider.processURL(URLStreamProvider.java:177) > at > org.apache.ambari.server.controller.internal.URLStreamProvider.readFrom(URLStreamProvider.java:105) > at > org.apache.ambari.server.controller.internal.URLStreamProvider.readFrom(URLStreamProvider.java:110) > > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java > a2c94f2 > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSReportPropertyProvider.java > 1ee3637 > > Diff: https://reviews.apache.org/r/30166/diff/ > > > Testing > ------- > > Unit tests passed > > > Thanks, > > Dmytro Sen > >
