-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30181/
-----------------------------------------------------------
Review request for Ambari, John Speidel, Robert Nettleton, and Tom Beerbower.
Bugs: AMBARI-9261
https://issues.apache.org/jira/browse/AMBARI-9261
Repository: ambari
Description
-------
The logic to enable or disable Kerberos is typically invoked when the Cluster
resource is updated. This occurs for several reasons, not all of them indicate
the state of Kerberos should be altered.
By processing all updated to the Cluster resource, the enable/disable Kerberos
may get invoked when not necessary causing _noise_ on the task list and
potentially generating an error condition if the KDC administrator credentials
are not available. Certain states of the system will trigger the
enable/disable Kerberos logic to perform tasks requiring the KDC administrator
credentials. If not explicitly handing the security state change, this behavior
is not desired.
To solve the issue, test the request on the update Cluster resource to see if
the security state property (`cluster-env/security_enabled`) has been altered,
if so invoke enable/disable Kerberos logic; else do not invoke enable/disable
Kerberos logic.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
dd18e8d
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
e713d7f
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
805b498
Diff: https://reviews.apache.org/r/30181/diff/
Testing
-------
Manually tested various cases on a test cluster
Added new unit tests
**Waiting for Jenkins tests to complete**
Thanks,
Robert Levas
