----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30183/#review69249 -----------------------------------------------------------
Ship it! Ship It! - Mahadev Konar On Jan. 22, 2015, 8:12 p.m., Sid Wagle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30183/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2015, 8:12 p.m.) > > > Review request for Ambari, Dmytro Sen, Mahadev Konar, and Myroslav > Papirkovskyy. > > > Bugs: AMBARI-9128 > https://issues.apache.org/jira/browse/AMBARI-9128 > > > Repository: ambari > > > Description > ------- > > - Hostname is currnetly socket.getfqdn() > - This should be configurable through a script. > > > Diffs > ----- > > > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py > 463c98c > > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/controller.py > e0ef804 > > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/host_info.py > 020b84e > > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/metric_collector.py > 05e94be > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/main.py > 37e77e5 > > ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestHostInfo.py > 4e63d6a > > ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestMetricCollector.py > 26a3edc > > Diff: https://reviews.apache.org/r/30183/diff/ > > > Testing > ------- > > ---------------------------------------------------------------------- > Ran 9 tests in 0.020s > > OK > ---------------------------------------------------------------------- > Total run:9 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Sid Wagle > >
