----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30214/#review69398 -----------------------------------------------------------
Ship it! Thanks for fixing this. - Robert Levas On Jan. 23, 2015, 11:08 a.m., Yurii Shylov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30214/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2015, 11:08 a.m.) > > > Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Robert > Levas. > > > Bugs: AMBARI-9300 > https://issues.apache.org/jira/browse/AMBARI-9300 > > > Repository: ambari > > > Description > ------- > > Test fails with next error: > {code} > > ====================================================================== > ERROR: test_get_params_from_filesystem_JAAS > (TestSecurityCommons.TestSecurityCommons) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File > "/var/lib/jenkins/workspace/test-your-branch-python/ambari-agent/src/test/python/resource_management/TestSecurityCommons.py", > line 146, in test_get_params_from_filesystem_JAAS > self.assertIn('test_jaas', result) > AttributeError: 'TestSecurityCommons' object has no attribute 'assertIn' > > ---------------------------------------------------------------------- > {code} > > According to [unittest > documentation|https://docs.python.org/2/library/unittest.html] assertIn was > added in python 2.7: > || Method||Checks that||New in|| > |assertIn(a, b)|a in b|2.7| > > > Diffs > ----- > > ambari-agent/src/test/python/resource_management/TestSecurityCommons.py > 602b88b > > Diff: https://reviews.apache.org/r/30214/diff/ > > > Testing > ------- > > {code} > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Agent ...................................... SUCCESS [8.471s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > {code} > > > Thanks, > > Yurii Shylov > >
