-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30246/
-----------------------------------------------------------
Review request for Ambari, Eugene Chekanskiy, John Speidel, Robert Nettleton,
and Yusaku Sako.
Bugs: AMBARI-9317
https://issues.apache.org/jira/browse/AMBARI-9317
Repository: ambari
Description
-------
There's no stdout to indicate progress / success for the tasks for principal
generation / keytab generation, etc.
Also, even just to know what command is actually being run to create the
principal, that will help folks with debugging. Or is that only shown in case
of a failure. Just want to make sure in the case of a problem, there is output
there to help folks.
Solution is to add logging facility
(`org.apache.ambari.server.serveraction.ActionLog`) to collect log messages for
use in when generating `org.apache.ambari.server.agent.CommandReport`
responses.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/serveraction/AbstractServerAction.java
ff396e6
ambari-server/src/main/java/org/apache/ambari/server/serveraction/ActionLog.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandler.java
b5de64f
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
6e53140
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java
947b033
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerAction.java
1860c97
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java
e965bd5
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java
c79b846
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerAction.java
cac45d3
ambari-server/src/test/java/org/apache/ambari/server/serveraction/ActionLogTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/30246/diff/
Testing
-------
Manual testing in test cluster to view required messages to STDOUT and STDERR
Added new test case `org.apache.ambari.server.serveraction.ActionLogTest`
#Jenmkins test results
Running org.apache.ambari.server.serveraction.ActionLogTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.124 sec
Ambari server test results
Tests run: 2598, Failures: 0, Errors: 0, Skipped: 15
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:00 h
[INFO] Finished at: 2015-01-24T15:52:08+00:00
[INFO] Final Memory: 43M/518M
[INFO] ------------------------------------------------------------------------
Thanks,
Robert Levas
