-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30276/
-----------------------------------------------------------
Review request for Ambari, John Speidel and Robert Nettleton.
Bugs: AMBARI-9324
https://issues.apache.org/jira/browse/AMBARI-9324
Repository: ambari
Description
-------
This appears to be happening when the KDC and/or KDC Admin hosts do not point
to a valid KDC, and when the relevant KDC does not _handle_ the indicated realm.
For the *host* issue, (in the cases that I tested), a
`org.apache.ambari.server.serveraction.kerberos.KerberosKDCConnectionException`
is being thrown but not caught to re-throw a
`java.lang.IllegalArgumentException`, which would generate the expected 400
error.
For the *realm* issue, the following error string is not being captured by the
logic to produce a
`org.apache.ambari.server.serveraction.kerberos.KerberosRealmException`.
```
kadmin: Cannot find KDC for requested realm while initializing kadmin interface
```
In any case,
`org.apache.ambari.server.serveraction.kerberos.KerberosRealmException` is not
being caught to re-throw a `java.lang.IllegalArgumentException`, which would
generate the expected 400 error.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
6620577
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java
c79b846
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java
d997159
Diff: https://reviews.apache.org/r/30276/diff/
Testing
-------
Manual testing in test cluster
Updated unit tests
# Jenkins test results
Running
org.apache.ambari.server.serveraction.kerberos.MITKerberosOperationHandlerTest
Tests run: 11, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.424 sec
Ambari server test suite
Tests run: 2598, Failures: 0, Errors: 0, Skipped: 15
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:05 h
[INFO] Finished at: 2015-01-26T15:27:44+00:00
[INFO] Final Memory: 43M/490M
[INFO] ------------------------------------------------------------------------
Thanks,
Robert Levas
