----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30172/#review69757 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py <https://reviews.apache.org/r/30172/#comment114568> Suggest replacing the import * with explicit imports wherever possible - Florian Barca On Jan. 22, 2015, 5:03 p.m., Artem Baranchuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30172/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2015, 5:03 p.m.) > > > Review request for Ambari, Eugene Chekanskiy, Florian Barca, and Jayush > Luniya. > > > Bugs: AMBARI-9269 > https://issues.apache.org/jira/browse/AMBARI-9269 > > > Repository: ambari > > > Description > ------- > > Add FLUME service to HDPWIN 2.1 and HDPWIN 2.2 > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume.py > 3f30809 > > ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_check.py > b93b8e8 > > ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py > a24e6ce > > ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py > efa22d4 > > ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params_linux.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params_windows.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/service_mapping.py > PRE-CREATION > ambari-server/src/main/resources/stacks/HDPWIN/2.1/role_command_order.json > 47cd50d > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/FLUME/configuration/flume-conf.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/FLUME/configuration/flume-env.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/FLUME/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/FLUME/metainfo.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/30172/diff/ > > > Testing > ------- > > Unix tests passed > Win cluster deployed success > > > Thanks, > > Artem Baranchuk > >
