----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30343/#review70004 -----------------------------------------------------------
Ship it! ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostComponentStateDAO.java <https://reviews.apache.org/r/30343/#comment114932> Why not used a named query here so that we can better catch JPQL errors at startup time. - Jonathan Hurley On Jan. 27, 2015, 8:15 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30343/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2015, 8:15 p.m.) > > > Review request for Ambari, Jonathan Hurley, Nate Cole, and Yurii Shylov. > > > Bugs: AMBARI-9365 > https://issues.apache.org/jira/browse/AMBARI-9365 > > > Repository: ambari > > > Description > ------- > > Install a cluster such that one host only has AMS component, so that it does > not create a host_version record for that host. > The Finalize Upgrade Action will fail because the host was never added to the > set of hosts with a correct version state. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostComponentStateDAO.java > fd1ce9e2d7e7b55e6a48cfc3dc559d94ae59c10f > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java > 1e489504ae3096f85f73628caff2d3bd0d6d8f84 > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java > 56281a2fe8808c3454ad97223a04582aec18e7b2 > > Diff: https://reviews.apache.org/r/30343/diff/ > > > Testing > ------- > > In-progress > > > Thanks, > > Alejandro Fernandez > >
