----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30391/#review70205 -----------------------------------------------------------
Ship it! Ship It! - Jonathan Hurley On Jan. 28, 2015, 9:57 p.m., Tom Beerbower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30391/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2015, 9:57 p.m.) > > > Review request for Ambari, Jonathan Hurley and Nate Cole. > > > Bugs: AMBARI-9388 > https://issues.apache.org/jira/browse/AMBARI-9388 > > > Repository: ambari > > > Description > ------- > > For an UpgradeItem (and Stage), only the following manual transitions are > currently allowed ... > HOLDING --> COMPLETED > HOLDING_FAILED --> PENDING (retry) > HOLDING_FAILED --> FAILED > HOLDING_TIMEDOUT --> PENDING (retry) > HOLDING_TIMEDOUT --> TIMEDOUT > > To allow abort from a manual step, we should allow HOLDING --> ABORTED > transition. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java > d5fa5b5 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java > b0e23e9 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StageResourceProvider.java > ce427a7 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java > c6a058d > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StageResourceProviderTest.java > c97de8a > > Diff: https://reviews.apache.org/r/30391/diff/ > > > Testing > ------- > > New unit test added. > > All tests pass ... > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 28:42 min > [INFO] Finished at: 2015-01-28T21:39:27-05:00 > [INFO] Final Memory: 42M/618M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Tom Beerbower > >
