----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30378/#review70386 -----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py <https://reviews.apache.org/r/30378/#comment115532> Not sure what this has to do with hbase configs. ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py <https://reviews.apache.org/r/30378/#comment115536> Is 23 a calculated value? better to show as basevalue + modifier. Where does this value come from? ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py <https://reviews.apache.org/r/30378/#comment115542> where does the gloabal memstore size value come from? ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py <https://reviews.apache.org/r/30378/#comment115546> pct.in.combinedcache ships with a default of 0.9. ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py <https://reviews.apache.org/r/30378/#comment115549> should be `if hbase_site_properties[prop_name1] == "offheap"` - nick dimiduk On Jan. 28, 2015, 9:45 a.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30378/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2015, 9:45 a.m.) > > > Review request for Ambari, Mahadev Konar, Nate Cole, nick dimiduk, and Tom > Beerbower. > > > Bugs: AMBARI-9383 > https://issues.apache.org/jira/browse/AMBARI-9383 > > > Repository: ambari > > > Description > ------- > > Off-heap caches in HBase have been implemented. Ambari should expose the > necessary configurations for a user to enable this feature. We're interested > only in the BucketCache off-heap mode. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params.py > 74cc0a4 > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/hbase-env.xml > f9c5885 > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/hbase-site.xml > e5b893f > ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py > 3d0ace2 > ambari-web/app/data/HDP2.2/site_properties.js efc6cb9 > > Diff: https://reviews.apache.org/r/30378/diff/ > > > Testing > ------- > > All tests passed > > > Thanks, > > Dmytro Sen > >
