----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30380/#review70375 -----------------------------------------------------------
Ship it! ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java <https://reviews.apache.org/r/30380/#comment115499> seems odd that the absense of a filter is the same as the filter containing the service. Just confirming that this is correct. ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java <https://reviews.apache.org/r/30380/#comment115500> This "may" be an issue. After I refactored Stacks, (BAD) changes were made regarding how config properties are returned from the service. Now when you ask for a services properties, you will also get any "excluded" properties. So, you will need to get the services excluded config types and remove all properties for those types from the properties that are returned. This is a complete mess and once again a HACK was introduced instead of fixing the root issue which was how a few callers were using the getProperties() method. - John Speidel On Jan. 28, 2015, 9:49 p.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30380/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2015, 9:49 p.m.) > > > Review request for Ambari, John Speidel and Robert Nettleton. > > > Bugs: AMBARI-9360 > https://issues.apache.org/jira/browse/AMBARI-9360 > > > Repository: ambari > > > Description > ------- > > Implement the ability to disable Kerberos from a cluster that was previously > configured for Kerberos. > > This entails reverting configuration properties set when Kerberos was enabled > to default values found in the stack. > > Principals will not be destroyed in the KDC and ketyab files will not be > removed from hosts. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java > 6bb9bf1 > > ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java > e976d81 > > Diff: https://reviews.apache.org/r/30380/diff/ > > > Testing > ------- > > Manual testing in clusters against MIT KDC and Active Directory > Updated Unit test > > # Jenkins test results > > Running org.apache.ambari.server.controller.KerberosHelperTest > Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.534 sec > > Ambari server test suite > Tests run: 2626, Failures: 0, Errors: 0, Skipped: 15 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 01:06 h > [INFO] Finished at: 2015-01-28T21:42:39+00:00 > [INFO] Final Memory: 44M/528M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Robert Levas > >
