-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30528/
-----------------------------------------------------------
Review request for Ambari, Robert Levas, Robert Nettleton, and Tom Beerbower.
Bugs: AMBARI-9367
https://issues.apache.org/jira/browse/AMBARI-9367
Repository: ambari
Description
-------
The new "add hosts" api is now completely broken and could return several
errors to the user depending on the topology assigned to the hosts being added.
This is a regression that was introduced in the patch for AMBARI-8868.
The root issue here is AMBARI-4782.
The patch for AMBARI-8868 attempted to resolve its issue without resolving the
root problem and in doing so, broke this functionality.
To fix this issue correctly, the root issue AMBARI-4782 needs to be resolved.
This will require coordination with the UI guys.
This patch is yet another hack to work around the root issue, AMBARI-4782.
Also, ensures that the kerberos client is installed to all hosts added to a
kerberized cluster.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java
b1e05cc
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
b5d2d6d
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java
337cc74
Diff: https://reviews.apache.org/r/30528/diff/
Testing
-------
Manual Functional testing:
Tested add hosts for both kerberized and non-kerberized clusters.
Unit Tests:
Updated existing unit tests.
All unit tests pass.
Thanks,
John Speidel