----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30559/#review70769 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java <https://reviews.apache.org/r/30559/#comment116175> This AmbariException will need to be caught upstream and translated to an IllegalArgumentException (or thrown from here) which will result in the expected 400 Bad Request response back to the user. If the AmbariException is not caught, it will result in a 500 Server Error to the user which is not appropriate. - John Speidel On Feb. 3, 2015, 4:41 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30559/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2015, 4:41 p.m.) > > > Review request for Ambari and Myroslav Papirkovskyy. > > > Bugs: AMBARI-9449 > https://issues.apache.org/jira/browse/AMBARI-9449 > > > Repository: ambari > > > Description > ------- > > Request info: > Request URL:<http://162.216.150.79:8080/api/v1/clusters/c1> > Request Method:PUT > Status Code:200 OK > > Data: > > > > > {"Clusters":{"desired_config":[ > {"type":"hive-site","tag":"version1421327958802","properties":{}}, > {"type":"yarn-site","tag":"version1421327958802","properties":{}} > ]}} > > > PUT call to server doesn't actually save configs and create config version, > but return status OK. > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java > 6b8a917 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > db17109 > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java > c4dfdb8 > > ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java > 8ebf2ce > > Diff: https://reviews.apache.org/r/30559/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
