----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30568/#review70785 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java <https://reviews.apache.org/r/30568/#comment116211> Not sure why you need a specific check for the custom command here - Nate Cole On Feb. 3, 2015, 1:19 p.m., Yurii Shylov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30568/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2015, 1:19 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate > Cole. > > > Bugs: AMBARI-9054 > https://issues.apache.org/jira/browse/AMBARI-9054 > > > Repository: ambari > > > Description > ------- > > Current implementation schedules request to every component to get its > version after server upgrade 1.7.0 - 2.0.0 was completed. It creates a stage > per every component and thus looks ugly. I'm in the process of rewriting it > to use AmbariCustomCommandExecutionHelper to call > save_component_version_to_structured_out() directly for every component. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > b8f3cd7 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java > a83d26d > > ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml > 777ced7 > > ambari-server/src/main/resources/custom_actions/scripts/request_component_info.py > PRE-CREATION > > Diff: https://reviews.apache.org/r/30568/diff/ > > > Testing > ------- > > preview > > > Thanks, > > Yurii Shylov > >
