----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30567/#review70808 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Direction.java <https://reviews.apache.org/r/30567/#comment116249> Works well enough for now. Ideally, we may want to store a tuple of a verb and its past and plural forms. E.g., stop, stopped is tricky. Maybe there's a javascript library for this. - Alejandro Fernandez On Feb. 3, 2015, 6:13 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30567/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2015, 6:13 p.m.) > > > Review request for Ambari, Jonathan Hurley and Tom Beerbower. > > > Bugs: AMBARI-9457 > https://issues.apache.org/jira/browse/AMBARI-9457 > > > Repository: ambari > > > Description > ------- > > * Modify token replace to support direction > * Replace textual representations where found to use the token > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 9426a2b > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java > 29e1c32 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java > 0d250d3 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java > f3fb0e8 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Direction.java > 373bf23 > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml > 28d0b1f > > ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java > d878fee > ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml > cc8bd0a > > Diff: https://reviews.apache.org/r/30567/diff/ > > > Testing > ------- > > Tests run: 2638, Failures: 0, Errors: 0, Skipped: 15 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 20:30.912s > [INFO] Finished at: Tue Feb 03 13:01:10 EST 2015 > [INFO] Final Memory: 31M/364M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
