> On Feb. 4, 2015, 11:20 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java, > > line 3058 > > <https://reviews.apache.org/r/30581/diff/1/?file=846656#file846656line3058> > > > > Is spec already trimmed for whitespace? May want to make a case > > insensitive comparison for starswith (using regex perhaps).
Alejandro, thank you for reviewing it. I fixed it. - jun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30581/#review71071 ----------------------------------------------------------- On Feb. 5, 2015, 5:59 a.m., jun aoki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30581/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2015, 5:59 a.m.) > > > Review request for Ambari. > > > Bugs: AMBARI-5042 > https://issues.apache.org/jira/browse/AMBARI-5042 > > > Repository: ambari > > > Description > ------- > > AMBARI-5042: Ambari Repo URL validator rejecting valid yum repo file:/// URL. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 7d78a4a > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java > 6aee03b > > Diff: https://reviews.apache.org/r/30581/diff/ > > > Testing > ------- > > Unit test passed > > > Thanks, > > jun aoki > >
