----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30662/#review71199 -----------------------------------------------------------
Ship it! Ship It! - Nate Cole On Feb. 5, 2015, 6:22 a.m., Tom Beerbower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30662/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2015, 6:22 a.m.) > > > Review request for Ambari and Nate Cole. > > > Bugs: AMBARI-9489 > https://issues.apache.org/jira/browse/AMBARI-9489 > > > Repository: ambari > > > Description > ------- > > An exception thrown while getting the view configuration from the archive > file could cause other views not to deploy. The exception should be handled > within readViewArchives() so that view deployment can proceed. > > For example ... > > > java.lang.IllegalArgumentException: is parameter must not be null > at > javax.xml.bind.helpers.AbstractUnmarshallerImpl.unmarshal(AbstractUnmarshallerImpl.java:199) > at > org.apache.ambari.server.view.ViewArchiveUtility.getViewConfigFromArchive(ViewArchiveUtility.java:73) > at > org.apache.ambari.server.view.ViewRegistry.readViewArchives(ViewRegistry.java:1297) > at > org.apache.ambari.server.view.ViewRegistry.readViewArchives(ViewRegistry.java:440) > at > org.apache.ambari.server.controller.AmbariServer.run(AmbariServer.java:349) > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java > db24954 > > ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java > 3a1c4eb > > Diff: https://reviews.apache.org/r/30662/diff/ > > > Testing > ------- > > Manual test. > New unit test added. > All tests pass. > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 30:27 min > [INFO] Finished at: 2015-02-04T17:00:18-05:00 > [INFO] Final Memory: 42M/622M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Tom Beerbower > >
